-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change Download Location of Fabric Binaries (#143)
The current scripts download the fabric binaries and place them in `/usr/local`. Modifying the host system in CI is generally bad practice. The `bootstrap.sh` script also downloads the binaries into the root of the `fabric-samples` repo. It is good practice for us to do the same in CI. We also have several samples that make an assumption about the location of these scripts. In the future we should re-evaluate these examples. Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
- Loading branch information
Brett Logan
authored
Mar 30, 2020
1 parent
1f283fc
commit 59c6641
Showing
3 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,3 +13,4 @@ | |
vendor/ | ||
.vscode | ||
.gradle | ||
.idea |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters