Change Download Location of Fabric Binaries #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current scripts download the fabric binaries and place them in `/usr/local`. Modifying the host system in CI is generally bad practice. The `bootstrap.sh` script also downloads the binaries into the root of the `fabric-samples` repo. It is good practice for us to do the same in CI. We also have several samples that make an assumption about the location of these scripts. In the future we should re-evaluate these examples. Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
lindluni
requested review from
christo4ferris,
denyeart,
harrisob,
jyellick,
lehors,
mastersingh24,
mbwhite and
sstone1
as code owners
sstone1
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current scripts download the fabric binaries and place them in
/usr/local. Modifying the host system in CI is generally bad practice. Thebootstrap.shscript also downloads the binaries into the root of thefabric-samplesrepo. It is good practice for us to do the same in CI. We also have several samples that make an assumption about the location of these scripts. In the future we should re evaluate these examples.Signed-off-by: Brett Logan brett.t.logan@ibm.com