Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Download Location of Fabric Binaries #143

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Change Download Location of Fabric Binaries #143

merged 1 commit into from
Mar 30, 2020

Commits on Mar 30, 2020

  1. Change Download Location of Fabric Binaries 

    The current scripts download the fabric binaries and place them
in `/usr/local`. Modifying the host system in CI is generally
bad practice. The `bootstrap.sh` script also downloads the
binaries into the root of the `fabric-samples` repo. It is
good practice for us to do the same in CI. We also have
several samples that make an assumption about the location
of these scripts. In the future we should re-evaluate these
examples.

Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
    Brett Logan committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    8ae778c View commit details
    Browse the repository at this point in the history