update to byfn.sh exec, fix bug in networkUp function #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"balance-transfer" app doesn't check all of the proposal responses. An app sends a transaction proposal to multiple peers and get multiple responses. However, the only first response "proposalResponses[0]" is checked repeatedly in the loop. This patch fixes the code to check all of the array value of proposalResponses correctly. Change-Id: Id61e691eb4d1c3a6c4a7a390584dfd74f1fc6196 Signed-off-by: Yuki Kondo <yuki.kondo@hal.hitachi.com>
Sample should use 'fcn' not 'functionName' in the sample curl calls and sample app. Change-Id: I4be92a0394fdf579195e9566d049aac0862d5888 Signed-off-by: Bret Harrison <beharrison@nc.rr.com>
Fix spelling error in instantiate-chaincode.js Fix Issue # 5311. Change-Id: Ib8654e2d12a6e3d138406d0bb8738e37ebee90d1 Signed-off-by: GeorgeLindsell <lindsellgeorge@gmail.com>
The README in "balance-transfer" should be fixed in the section: https://github.com/hyperledger/fabric-samples/tree/master/ balance-transfer#running-the-sample-program 1. Broken link There is a link to "Sample REST APIs Requests" which is broken. This is linked to non-existent path on fabric-sdk-node repository. I believe the intended link is to https://github.com/hyperledger/fabric-samples/tree/master/ balance-transfer#sample-rest-apis-requests 2. Instruction to start node application. There is no instruction to start node application. If we execute the REST APIs according to the current README, we can't get any responses since node application is not working. We need to execute the following steps before calling REST APIs. - npm install - PORT=4000 node app fix repo names Change-Id: I9ec0ec18bb36addd6c8371481dc8cfe645053ec6 Signed-off-by: Yuki Kondo <yuki.kondo@hal.hitachi.com> Signed-off-by: Christopher Ferris <chrisfer@us.ibm.com>
Git Bash is a prereq for Windows users required to run the various sample scripts. Git Bash by default will convert paths and this causes the issue identified by FAB-5392. Luckily Git Bash provides supports an environment variable to override this behavior. Change-Id: I66e52eb2953c0dcc9f04903a1fd1fd94d19b75ce Signed-off-by: Gari Singh <gari.r.singh@gmail.com>
Add a script to allow users to preload the Fabric docker images without having to run the curl command in the RTD. Change-Id: I3b6c682c3e2ab1f230f7af8c3ce0b95bbb8fd024 Signed-off-by: Christopher Ferris <chrisfer@us.ibm.com>
Introduce delay as configurable variable for byfn.sh Change-Id: I8ab05f44c68b36bd95f175c9b5f5091d11fa7083 Signed-off-by: Krishna Harsha Voora <krishvoor@in.ibm.com>
This patch set deletes unused docker-compose environment variables. Now CouchDB section in docker-compose file uses DB_URL env variables. But the variables are not used in CouchDB container. Change-Id: I8e84255e1ea00498b787bdd4042cdb909a96667c Signed-off-by: Nao Nishijima <nao.nishijima@hal.hitachi.com>
- Made it possible to deploy the app (both the client and fabric backend) to a location other than localhost - Made it possible to work with a backend over grpc instead of always assuming grpcs - Made the list of target peers for instantiate and invoke calls to be optional - Enabled target networks to be controlled by an env variable Change-Id: Ie394cf7e8f6ed47d970d4be992f2f6a0394fff7f Signed-off-by: Jim Zhang <jzhang@us.ibm.com>
Using the -f flag is possible to specify the docker-compose file to use on the byfn.sh script to have a standar way to test the different configurations for the samples project. The defautl is 'docker-compose-cli.yaml' -h output updated as well. Fix Issue # FAB-5576. Change-Id: I8766ab930f05d9c4934b149872b9de3a299ff345 Signed-off-by: dsanchezseco <d.seco@protonmail.com>
fixed the unrecognized option on byfn.sh script when providing the docker-compose file to start the network Fix Issue # FAB-5603 Change-Id: I74234c53d8f82cbf2678f80aa3a898c3ec51c422 Signed-off-by: dsanchezseco <d.seco@protonmail.com>
Currently peer and couchdb containers started simulateously, while clearly peer depends on availability of the state db, therfore this commit add dependency declaration into docker-compose.yaml file to make sure to start couchdb before peer container. Change-Id: Id2302a32fba9234d04ef3f4e6bd24ac92a766995 Signed-off-by: Artem Barger <bartem@il.ibm.com>
update byfn.sh script to enable couchdb tests. Follow the below steps from first-network dir ./byfn.sh -m generate -c ibmblockchain ./byfn.sh -m up -c ibmblockchain -s couchdb ./byfn.sh -m down Change-Id: If84e744b35a96fa1ed314dff0abf845ab363fcbb Signed-off-by: rameshbabu <rameshbabu.thoomu@gmail.com>
…rst network). ran dos2unix against byfn.sh, script.sh, fabric-preload.sh to make them executable
|
Thank you for your contribution! This is a read only mirror, however. Please submit your change using gerrit. you would need to check out the repo here: https://gerrit.hyperledger.org/r/#/admin/projects/fabric-samples and make your edits, pushing them to gerrit here is a walkthrough for zephyrproject which is much the same WRT setting up an LFID, adding ssh keys, etc: feel free to ask on rocket.chat - https://chat.hyperledger.org/ - discuss in #fabric one note: when you set up your LFID do not use social logins the first time, create the account and you can add social logins later |
ghost
closed this
ghost
pushed a commit
that referenced
this pull request
Feb 12, 2018
This change brings a new set of scripts and configuration files to the first-network sample to make it easier for people to follow the new tutorial on how to add a third org to the network setup in BYFN. To function properly the new Extend You First Network script (eyfn.sh) must be run after byfn.sh is run and with the same parameters. So, valid uses include: ./byfn.sh up ./eyfn.sh up or ./byfn.sh up -c testchannel -s couchdb -l node ./eyfn.sh up -c testchannel -s couchdb -l node A single './eyfn.sh down' command is however necessary to take the whole network down. Patch-set #2: fixes ./eyfn.sh down Patch-set #3: removed unused option from Usage and spurious whitespaces Patch-set #4: added missing test file Change-Id: I9c926b52f2243dda1c5f9368112c314a6c5c6929 Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
mplescano
pushed a commit
to mplescano/fabric-samples
that referenced
this pull request
Oct 4, 2018
This change brings a new set of scripts and configuration files to the first-network sample to make it easier for people to follow the new tutorial on how to add a third org to the network setup in BYFN. To function properly the new Extend You First Network script (eyfn.sh) must be run after byfn.sh is run and with the same parameters. So, valid uses include: ./byfn.sh up ./eyfn.sh up or ./byfn.sh up -c testchannel -s couchdb -l node ./eyfn.sh up -c testchannel -s couchdb -l node A single './eyfn.sh down' command is however necessary to take the whole network down. Patch-set hyperledger#2: fixes ./eyfn.sh down Patch-set hyperledger#3: removed unused option from Usage and spurious whitespaces Patch-set hyperledger#4: added missing test file Change-Id: I9c926b52f2243dda1c5f9368112c314a6c5c6929 Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
mbwhite
pushed a commit
to mbwhite/fabric-samples
that referenced
this pull request
Sep 29, 2021
Feature/tldr
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is posted in StackOverflow here. The networkUp function in byfn.sh calls docker compose twice, once prior to the
IF_COUCHDBtest and a second time within the scope of that if statement. The networkUp function also fails to set the DELAY argument on either of the docker-compose requests within the if statement. In this pull request, I've commented out line 113 (the duplicate docker-compose request) and addedDELAY=$CLI_DELAYto each of the docker-compose statements inside the if structure. The default setting of 3 seconds is now passed correctly to docker-compose and the network up function processes correctly.