Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

byfn.sh: CURRENT_DIR issue with long paths fixed #4

Closed
wants to merge 1 commit into from
Closed

byfn.sh: CURRENT_DIR issue with long paths fixed #4

wants to merge 1 commit into from

Conversation

M0Rf30
Copy link

@M0Rf30 M0Rf30 commented Aug 17, 2017

Double quoted CURRENT_DIR var to allow right expansion for long paths. Before it caused a "too many arguments" for cd command

Double quoted CURRENT_DIR var to allow right expansion for long paths. Before it cause a "too many arguments" for cd command
@ghost
Copy link

ghost commented Aug 18, 2017

Thank you for your contribution! This is a read only mirror, however. Please submit your change using gerrit.

you would need to check out the repo here: https://gerrit.hyperledger.org/r/#/admin/projects/fabric-samples and make your edits, pushing them to gerrit

here is a walkthrough for zephyrproject which is much the same WRT setting up an LFID, adding ssh keys, etc:
https://www.zephyrproject.org/doc/1.1.0/collaboration/code/gerrit_accounts.html

feel free to ask on rocket.chat - https://chat.hyperledger.org/ - discuss in #fabric

one note: when you set up your LFID do not use social logins the first time, create the account and you can add social logins later

@ghost ghost closed this Aug 18, 2017
@M0Rf30
Copy link
Author

M0Rf30 commented Aug 21, 2017

sorry but how to pull to gerrit?
using
git push origin HEAD:refs/for/branch
doesn't grant me write access for reviews

ghost pushed a commit that referenced this pull request Feb 12, 2018
This change brings a new set of scripts and configuration files to the
first-network sample to make it easier for people to follow the new
tutorial on how to add a third org to the network setup in BYFN.

To function properly the new Extend You First Network script (eyfn.sh)
must be run after byfn.sh is run and with the same parameters. So,
valid uses include:

./byfn.sh up
./eyfn.sh up

or

./byfn.sh up -c testchannel -s couchdb -l node
./eyfn.sh up -c testchannel -s couchdb -l node

A single './eyfn.sh down' command is however necessary to take the
whole network down.

Patch-set #2: fixes ./eyfn.sh down
Patch-set #3: removed unused option from Usage and spurious whitespaces
Patch-set #4: added missing test file

Change-Id: I9c926b52f2243dda1c5f9368112c314a6c5c6929
Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
mplescano pushed a commit to mplescano/fabric-samples that referenced this pull request Oct 4, 2018
This change brings a new set of scripts and configuration files to the
first-network sample to make it easier for people to follow the new
tutorial on how to add a third org to the network setup in BYFN.

To function properly the new Extend You First Network script (eyfn.sh)
must be run after byfn.sh is run and with the same parameters. So,
valid uses include:

./byfn.sh up
./eyfn.sh up

or

./byfn.sh up -c testchannel -s couchdb -l node
./eyfn.sh up -c testchannel -s couchdb -l node

A single './eyfn.sh down' command is however necessary to take the
whole network down.

Patch-set hyperledger#2: fixes ./eyfn.sh down
Patch-set hyperledger#3: removed unused option from Usage and spurious whitespaces
Patch-set hyperledger#4: added missing test file

Change-Id: I9c926b52f2243dda1c5f9368112c314a6c5c6929
Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
ghost pushed a commit that referenced this pull request Jul 30, 2019
This patch adds unit test for chaincode/sacc.

The positive test cases are aligned with the manual testing procedures
described in `fabric/docs/source/chaincode4ade.rst`.

FAB-15625 #done

Patch-set #4: adjust to new shim Mockup location

Change-Id: Ic3625e885f6e49507859af7d5f0bfa136eb7a757
Signed-off-by: Tatsuya Sato <Tatsuya.Sato@hal.hitachi.com>
Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
mbwhite pushed a commit to mbwhite/fabric-samples that referenced this pull request Sep 29, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant