[FAB-17539] Always remember anchor peers in membership #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
reviewed
Jun 19, 2020
yacovm
requested changes
Jun 19, 2020
wenjianqiao
force-pushed
the
fab17539
branch
2 times, most recently
from
0aa08fd to
fabbac9
Compare
|
@yacovm I have addressed your comments. However, there were UT/IT failures (may be flakes). |
wenjianqiao
commented
Jun 22, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yacovm
reviewed
Jun 24, 2020
yacovm
reviewed
Jun 24, 2020
yacovm
reviewed
Jun 24, 2020
yacovm
reviewed
Jun 24, 2020
wenjianqiao
force-pushed
the
fab17539
branch
2 times, most recently
from
f2e7af3 to
3671d42
Compare
Gossip service removes a peer from its membership if the peer's alive message is expired. However, it should always remember the anchor peers and bootstrap peers in order for the peer to reconnect. Gossip already remembers bootstrap peers. This PR adds code to track all anchor peers' endpoints and updates the expiration callback function to not delete anchor peers. Signed-off-by: Wenjian Qiao <wenjianq@gmail.com>
|
Hit gossip CI flake https://jira.hyperledger.org/browse/FAB-17451, problem 1)
|
|
/ci-run |
yacovm
approved these changes
Jun 24, 2020
sijocherian
pushed a commit
to sijocherian/fabric
that referenced
this pull request
Jun 28, 2020
) Gossip service removes a peer from its membership if the peer's alive message is expired. However, it should always remember the anchor peers and bootstrap peers in order for the peer to reconnect. Gossip already remembers bootstrap peers. This PR adds code to track all anchor peers' endpoints and updates the expiration callback function to not delete anchor peers. Signed-off-by: Wenjian Qiao <wenjianq@gmail.com>
|
Backport to release-1.4 via PR #1815 |
wenjianqiao
added a commit
to wenjianqiao/fabric
that referenced
this pull request
Aug 27, 2020
) Gossip service removes a peer from its membership if the peer's alive message is expired. However, it should always remember the anchor peers and bootstrap peers in order for the peer to reconnect. Gossip already remembers bootstrap peers. This PR adds code to track all anchor peers' endpoints and updates the expiration callback function to not delete anchor peers. Signed-off-by: Wenjian Qiao <wenjianq@gmail.com>
yacovm
pushed a commit
that referenced
this pull request
Aug 31, 2020
Gossip service removes a peer from its membership if the peer's alive message is expired. However, it should always remember the anchor peers and bootstrap peers in order for the peer to reconnect. Gossip already remembers bootstrap peers. This PR adds code to track all anchor peers' endpoints and updates the expiration callback function to not delete anchor peers. Signed-off-by: Wenjian Qiao <wenjianq@gmail.com>
ConstCh
pushed a commit
to eldis/fabric
that referenced
this pull request
Sep 3, 2020
) (hyperledger#1815) Gossip service removes a peer from its membership if the peer's alive message is expired. However, it should always remember the anchor peers and bootstrap peers in order for the peer to reconnect. Gossip already remembers bootstrap peers. This PR adds code to track all anchor peers' endpoints and updates the expiration callback function to not delete anchor peers. Signed-off-by: Wenjian Qiao <wenjianq@gmail.com> # Conflicts: # gossip/service/gossip_service_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenjian Qiao wenjianq@gmail.com
Type of change
Description
Gossip service removes a peer from its membership if the peer's alive message is expired.
However, it should not remove the anchor peers or bootstrap peers in order for
the peer to reconnect. Gossip already remembers bootstrap peers. This PR adds code to track
all anchor peers' endpoints and updates the expiration callback function to not delete
anchor peers.
Additional details
Related issues
https://jira.hyperledger.org/browse/FAB-17539