[FAB-17539] Always remember anchor peers in membership (bp #1422) #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenjianqiao
force-pushed
the
anchorpeer_backport
branch
2 times, most recently
from
d4c450c to
4656da4
Compare
|
/ci-run |
|
AZP build triggered! |
wenjianqiao
force-pushed
the
anchorpeer_backport
branch
from
4656da4 to
cb0de67
Compare
yacovm
reviewed
Aug 27, 2020
) Gossip service removes a peer from its membership if the peer's alive message is expired. However, it should always remember the anchor peers and bootstrap peers in order for the peer to reconnect. Gossip already remembers bootstrap peers. This PR adds code to track all anchor peers' endpoints and updates the expiration callback function to not delete anchor peers. Signed-off-by: Wenjian Qiao <wenjianq@gmail.com>
wenjianqiao
force-pushed
the
anchorpeer_backport
branch
from
cb0de67 to
d73f193
Compare
|
/ci-run |
|
AZP build triggered! |
yacovm
approved these changes
Aug 31, 2020
ConstCh
pushed a commit
to eldis/fabric
that referenced
this pull request
Sep 3, 2020
) (hyperledger#1815) Gossip service removes a peer from its membership if the peer's alive message is expired. However, it should always remember the anchor peers and bootstrap peers in order for the peer to reconnect. Gossip already remembers bootstrap peers. This PR adds code to track all anchor peers' endpoints and updates the expiration callback function to not delete anchor peers. Signed-off-by: Wenjian Qiao <wenjianq@gmail.com> # Conflicts: # gossip/service/gossip_service_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenjian Qiao wenjianq@gmail.com
This is a backport of pull request #1422 via cherry pick and manual updates due to merge conflicts and code differences between v1.4 and v2.0.
Type of change
Description
Gossip service removes a peer from its membership if the peer's alive message is expired.
However, it should not remove the anchor peers or bootstrap peers in order for
the peer to reconnect. Gossip already remembers bootstrap peers. This PR adds code to track
all anchor peers' endpoints and updates the expiration callback function to not delete
anchor peers.
Additional details
Related issues
https://jira.hyperledger.org/browse/FAB-17539