Build release binaries and Docker images for arm64 #3836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Kneubuhl <jkneubuh@us.ibm.com>
jkneubuh
force-pushed
the
feature/rel2.5/arm64
branch
from
d0c5026 to
cf199d1
Compare
denyeart
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR publishes multi-arch Docker images to ghcr.io and prepares native CLI binaries as part of the release process.
(Note: for the 2.5 release line, the
DOCKER_REGISTRYattribute in release.yaml will need to be updated to refer to docker.io. The use of the ghcr.io container registry allows us to run through a few test pipelines and recover from errors without pulling in the HL team to manually scrub artifacts.)To trigger the release action, draft a new GH Release, applying a semrev tag (e.g. v2.5.0-alpha) to a target branch. When GH applies the release tag, this will trigger the new release pipeline, generating docker images and fabric CLI binaries.
Signed-off-by: Josh Kneubuhl jkneubuh@us.ibm.com
Type of change
Description
This PR adds support for multi-arch Docker images, generated with the buildx builder.
This PR also modifies the fabric native binaries to include the {{ github.ref_name }} directly when compiling the routine metadata. This allows for a semantic revision (e.g. v2.5.0, v2.5.0-alpha, etc.) or branch relative tags to be associated with the images and binaries.
Additional details
Related issues