Publish multi-arch docker images and binaries for arm64, amd64 #3847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkneubuh
changed the title
jkneubuh
force-pushed
the
feature/e-merge
branch
from
b7caece to
a73c483
Compare
|
I think this looks good and is an accurate forward port of the release-2.5 changes that have been validated in that branch. The changes to the Dockerfiles are slightly different than what was done in release-2.5, because Artem @C0rWin has previously updated the Dockerfiles for ARM in ac31c57. So let's ask @C0rWin to review also and make sure he is good with this approach. |
|
The etcdraft unit test failure is a known flake and can be ignored, it is being looked at by @Param-S |
|
I'll go ahead and merge to keep the branches consistent, but @C0rWin and others please do holler if you see anything not correct. |
jkneubuh
force-pushed
the
feature/e-merge
branch
from
aaa0933 to
a73c483
Compare
Signed-off-by: Josh Kneubuhl <jkneubuh@us.ibm.com>
jkneubuh
force-pushed
the
feature/e-merge
branch
from
a73c483 to
44e3568
Compare
denyeart
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Kneubuhl jkneubuh@us.ibm.com
Type of change
Description
Builds multi-arch Docker images and native binaries for arm64 and amd64.
Additional details
This PR is a "cherry-pick" (back/forward) port of the following PRs from the release-2.5 branch "up" into the mainline:
Related issues