Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish release artifacts to conventional installation paths #3843

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

jkneubuh
Copy link
Contributor

@jkneubuh jkneubuh commented Dec 8, 2022

Signed-off-by: Josh Kneubuhl jkneubuh@us.ibm.com

Type of change

  • Bug fix

Description

This PR updates the release pipeline to publish binary assets to the traditional paths within the GH Release.

In addition, this applies the TWO_DIGIT_VERSION release tag, without the leading 'v', to determine the coordinates of the embedded ccenv builder image.

This PR updates the target version of install-fabric.sh to 2.5.0 / 1.5.6, and includes an optional FABRIC_DOCKER_REGISTRY environment variable in order to override the default Docker Hub container registry.

Related issues

Release Note

@jkneubuh jkneubuh requested a review from a team as a code owner December 8, 2022 21:27
@jkneubuh jkneubuh marked this pull request as draft December 8, 2022 21:34
@jkneubuh jkneubuh force-pushed the rel-2.5/feature/no-vee branch from 1d91398 to 8d79d38 Compare December 8, 2022 21:53
@jkneubuh jkneubuh marked this pull request as ready for review December 8, 2022 21:56
@jkneubuh jkneubuh force-pushed the rel-2.5/feature/no-vee branch from 8d79d38 to e57ad16 Compare December 8, 2022 23:00
@jkneubuh jkneubuh force-pushed the rel-2.5/feature/no-vee branch from 0e9287a to edc838c Compare December 9, 2022 12:45
@@ -49,8 +50,8 @@ print_help()
{
printf 'Usage: %s [-f|--fabric-version <arg>] [-c|--ca-version <arg>] <comp-1> [<comp-2>] ... [<comp-n>] ...\n' "$0"
printf '\t%s\n' "<comp> Component to install, one or more of docker | binary | samples | podman First letter of component also accepted; If none specified docker | binary | samples is assumed"
printf '\t%s\n' "-f, --fabric-version: FabricVersion (default: '2.4.4')"
printf '\t%s\n' "-c, --ca-version: Fabric CA Version (default: '1.5.5')"
printf '\t%s\n' "-f, --fabric-version: FabricVersion (default: '2.5.0')"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too.

Signed-off-by: Josh Kneubuhl <jkneubuh@us.ibm.com>
@jkneubuh jkneubuh force-pushed the rel-2.5/feature/no-vee branch from edc838c to b8d9cc9 Compare December 9, 2022 12:53
@denyeart denyeart merged commit db97461 into hyperledger:release-2.5 Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants