-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dead link to Go Chaincode SDK #476
Conversation
The link to the go chaincode SDK was missing and the documentation was pointing to the old location of the shim package. Signed-off-by: Matthias Fasching <fasching.matthias@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
As a follow-on, we should consider whether or not we want the 1.4 documentation to point to If we want to use the older package (and get some godoc), we can sort of make it work by linking to the real code in the release-1.4 branch and using gopkg.in for godoc. https://github.com/hyperledger/fabric/tree/release-1.4/core/chaincode/shim @pamandrejko, @nikhil550, @joealewine - have an opinion? |
It makes sense to have the 1.4 doc point to the release-1.4 branch of the shim package. The master branch already points to the new version of the chaincode sdk and API. If you want I can update this PR accordingly |
@fasmat I agree 1.4 doc should point to the relevant release-1.4 code. This PR has been merged, but you could update in a subsequent PR. |
See #479 |
As discussed in #476 Signed-off-by: Matthias Fasching <fasching.matthias@gmail.com>
As discussed in hyperledger#476 Signed-off-by: Matthias Fasching <fasching.matthias@gmail.com>
As discussed in hyperledger#476 Signed-off-by: Matthias Fasching <fasching.matthias@gmail.com>
Type of change
Description
The link to the go chaincode SDK was missing and the documentation was pointing to the old location of the shim package.
Additional details
N/A
Related issues
N/A