Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dead link to Go Chaincode SDK #476

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Update dead link to Go Chaincode SDK #476

merged 1 commit into from
Jan 9, 2020

Conversation

fasmat
Copy link

@fasmat fasmat commented Jan 9, 2020

Type of change

  • Documentation update

Description

The link to the go chaincode SDK was missing and the documentation was pointing to the old location of the shim package.

Additional details

N/A

Related issues

N/A

@fasmat fasmat requested a review from a team as a code owner January 9, 2020 12:26
The link to the go chaincode SDK was missing and the documentation was pointing to the old location of the shim package.

Signed-off-by: Matthias Fasching <fasching.matthias@gmail.com>
Copy link
Contributor

@sykesm sykesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@sykesm sykesm merged commit 1b6bea7 into hyperledger:release-1.4 Jan 9, 2020
@sykesm
Copy link
Contributor

sykesm commented Jan 9, 2020

As a follow-on, we should consider whether or not we want the 1.4 documentation to point to fabric-chaincode-go or the older chaincode shim in fabric.

If we want to use the older package (and get some godoc), we can sort of make it work by linking to the real code in the release-1.4 branch and using gopkg.in for godoc.

https://github.com/hyperledger/fabric/tree/release-1.4/core/chaincode/shim
https://godoc.org/gopkg.in/hyperledger/fabric.v1/core/chaincode/shim

@pamandrejko, @nikhil550, @joealewine - have an opinion?

@fasmat
Copy link
Author

fasmat commented Jan 9, 2020

It makes sense to have the 1.4 doc point to the release-1.4 branch of the shim package. The master branch already points to the new version of the chaincode sdk and API.

If you want I can update this PR accordingly

@denyeart
Copy link
Contributor

denyeart commented Jan 9, 2020

@fasmat I agree 1.4 doc should point to the relevant release-1.4 code. This PR has been merged, but you could update in a subsequent PR.

@fasmat
Copy link
Author

fasmat commented Jan 9, 2020

See #479

@fasmat fasmat deleted the patch-1 branch January 9, 2020 15:43
mastersingh24 pushed a commit that referenced this pull request Jan 10, 2020
As discussed in #476

Signed-off-by: Matthias Fasching <fasching.matthias@gmail.com>
GrapeBaBa pushed a commit to zhigui-projects/fabric that referenced this pull request Feb 5, 2020
As discussed in hyperledger#476

Signed-off-by: Matthias Fasching <fasching.matthias@gmail.com>
C0rWin pushed a commit to C0rWin/fabric that referenced this pull request Sep 15, 2020
As discussed in hyperledger#476

Signed-off-by: Matthias Fasching <fasching.matthias@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants