Go SDK link should point to 1.4 release #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in #476 Signed-off-by: Matthias Fasching <fasching.matthias@gmail.com>
|
Let me elaborate a bit on the comments I made in #476. For those that continue to use 1.4, we obviously want the links in the doc to work. We would also prefer for the links to point to versions that correspond to the release we're documenting. This change accomplishes that. Beyond that, however, we probably need to improve the doc around the actual imports and code for 1.4 chaincode. Those building chaincode for 1.4 need to decide if they want to migrate to fabric-chaincode-go (which is backwards compatible) or vendor their own version of the shim from release-1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The links should point to the 1.4 release of the shim package and its documentation as discussed in #476.
Additional details
N/A
Related issues
#476