Pass 409 Conflict back to FireFly Core #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
awrichar
reviewed
Jun 19, 2023
| @@ -94,7 +96,13 @@ export class BlockchainConnectorService { | |||
| this.logger.warn( | |||
| `${request?.path} <-- HTTP ${response?.status} ${response?.statusText}: ${errorMessage}`, | |||
| ); | |||
| throw new InternalServerErrorException(errorMessage); | |||
| if (response?.status == HttpStatus.CONFLICT) { | |||
There was a problem hiding this comment.
Highlighting (for the record) that we'll generally only reach this block for a "non-retryable" error. The default configuration for which errors are retryable seems to be only those whose error text matches the regex .*ECONN.* (although it can be overridden).
So I think unless you override the retry config to be very generic, 409s should generally bubble up to here, and therefore bubble up to FireFly.
awrichar
approved these changes
Jun 19, 2023
|
We'll want to port this to ERC1155 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change in FireFly core means that now sometimes conflict detection will be handled by the blockchain connector itself. This means that we need to pass this status back to FireFly core, rather than always returning 500 here.