Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass 409 Conflict back to FireFly Core #137

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Pass 409 Conflict back to FireFly Core #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/tokens/blockchain.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
import { ClientRequest } from 'http';
import { HttpService } from '@nestjs/axios';
import {
ConflictException,
HttpStatus,
Injectable,
InternalServerErrorException,
Logger,
Expand Down Expand Up @@ -94,7 +96,13 @@ export class BlockchainConnectorService {
this.logger.warn(
`${request?.path} <-- HTTP ${response?.status} ${response?.statusText}: ${errorMessage}`,
);
throw new InternalServerErrorException(errorMessage);
if (response?.status == HttpStatus.CONFLICT) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighting (for the record) that we'll generally only reach this block for a "non-retryable" error. The default configuration for which errors are retryable seems to be only those whose error text matches the regex .*ECONN.* (although it can be overridden).

So I think unless you override the retry config to be very generic, 409s should generally bubble up to here, and therefore bubble up to FireFly.

// Pass a 409 through
throw new ConflictException(errorMessage);
} else {
// Otherwise always return a 500 if the blockchain connector request wasn't successful
throw new InternalServerErrorException(errorMessage);
}
}
throw err;
});
Expand Down