Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 2-level drilldown for token accounts #71

Merged
merged 11 commits into from
Nov 10, 2021

Conversation

awrichar
Copy link
Contributor

@awrichar awrichar commented Nov 4, 2021

This depends on some API changes in hyperledger/firefly#313.

FireFly_Explorer

FireFly_Explorer

FireFly_Explorer

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
First page lists all pools with token holdings, then the next level shows
details on all holdings within a particular pool.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar
Copy link
Contributor Author

awrichar commented Nov 4, 2021

Changed the header on the account details page for a particular pool (just use the pool name). Here's a new screenshot, showing a fungible pool:

FireFly_Explorer

Copy link
Contributor

@dechdev dechdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left some comments

src/modules/tokens/views/Transfers/Transfers.tsx Outdated Show resolved Hide resolved
src/modules/tokens/views/Accounts/AccountPools.tsx Outdated Show resolved Hide resolved
src/modules/tokens/views/Accounts/AccountDetails.tsx Outdated Show resolved Hide resolved
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar awrichar force-pushed the accounts branch 2 times, most recently from 4a1ad13 to 2625cae Compare November 4, 2021 17:26
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@awrichar
Copy link
Contributor Author

awrichar commented Nov 4, 2021

Added a few additional changes to surface when a transfer has a message attached. Note that the "link" to the message is currently non-functional - might need a consult on how to link across modules to a specific message.

FireFly_Explorer

FireFly_Explorer

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Copy link
Member

@shorsher shorsher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, made this issue #72 to track the work for creating a new message details view.

@awrichar awrichar merged commit 3334f76 into hyperledger:main Nov 10, 2021
@awrichar awrichar deleted the accounts branch November 10, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants