Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional cleanup to support tokens UI #313

Merged
merged 8 commits into from
Nov 9, 2021

Conversation

awrichar
Copy link
Contributor

@awrichar awrichar commented Nov 3, 2021

Part of #218

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #313 (3089b5f) into main (ce179d5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              main      #313    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          224       231     +7     
  Lines        12374     12542   +168     
==========================================
+ Hits         12374     12542   +168     
Impacted Files Coverage Δ
internal/apiserver/route_get_token_accounts.go 100.00% <ø> (ø)
internal/apiserver/route_get_token_pool_by_name.go 100.00% <ø> (ø)
...nternal/apiserver/route_get_token_pools_by_type.go 100.00% <ø> (ø)
...nal/apiserver/route_get_token_transfers_by_pool.go 100.00% <ø> (ø)
pkg/fftypes/event.go 100.00% <ø> (ø)
pkg/fftypes/message.go 100.00% <ø> (ø)
internal/apiserver/route_get_msg_by_id.go 100.00% <100.00%> (ø)
internal/apiserver/route_get_msgs.go 100.00% <100.00%> (ø)
...nternal/apiserver/route_get_token_account_pools.go 100.00% <100.00%> (ø)
...rnal/apiserver/route_get_token_accounts_by_pool.go 100.00% <100.00%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16dcab6...3089b5f. Read the comment docs.

Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @awrichar - does feel more consistent with this use of the UUID

@peterbroadhurst peterbroadhurst merged commit feac44a into hyperledger:main Nov 9, 2021
@peterbroadhurst peterbroadhurst deleted the balances branch November 9, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants