Surface message rejection reason to API #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
requested review from
peterbroadhurst,
nguyer,
shorsher and
nickgaski
as code owners
awrichar
commented
Jun 7, 2023
| @@ -618,10 +622,6 @@ func (ag *aggregator) readyForDispatch(ctx context.Context, msg *core.Message, d | |||
| var handlerResult definitions.HandlerResult | |||
| handlerResult, err = ag.definitions.HandleDefinitionBroadcast(ctx, &state.BatchState, msg, data, tx) | |||
| log.L(ctx).Infof("Result of definition broadcast '%s' [%s]: %s", msg.Header.Tag, msg.Header.ID, handlerResult.Action) | |||
| if handlerResult.Action == core.ActionReject { | |||
| log.L(ctx).Infof("Definition broadcast '%s' rejected: %s", msg.Header.ID, err) | |||
| err = nil | |||
There was a problem hiding this comment.
Note that this block should now fall through and return the error to its caller (line 528), which will then log the error and add it to the message, but should not cause retries. I'm trying to be very careful not to reintroduce the bugs fixed in #1278.
Codecov Report
@@ Coverage Diff @@
## main #1336 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 314 314
Lines 21419 21453 +34
===========================================
+ Hits 21419 21449 +30
- Misses 0 2 +2
- Partials 0 2 +2
|
peterbroadhurst
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to add a "reject_reason" to messages (ie to database and API), which will be populated with the error text whenever a message is rejected. Previously this reason would only be logged, so the hope is that this assists in debugging when a message is rejected for an unexpected reason.
Note that this does slightly reduce the performance of inserting rejected messages, because we must insert them one-by-one instead of in one large update (but I think the net benefit of having the extra info far outweighs the cost, since this is a non-happy path anyway).