Correctly parse blockchain subscription name when delivering events #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the namespace can be accurately extracted. Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
awrichar
requested review from
peterbroadhurst,
nguyer and
shorsher
as code owners
nguyer
reviewed
Jul 26, 2023
| @@ -334,7 +334,7 @@ func buildBatchPin(ctx context.Context, event *blockchain.Event, params *BatchPi | |||
| func GetNamespaceFromSubName(subName string) string { | |||
| var parts = strings.Split(subName, "-") | |||
| // Subscription names post version 1.1 are in the format `ff-sub-<namespace>-<listener ID>` | |||
| if len(parts) != 4 { | |||
| if len(parts) < 4 { | |||
There was a problem hiding this comment.
Is there a possibility that an old subscription could still hit this codepath if it contains a UUID?
There was a problem hiding this comment.
Yeaaa there is... 🫠
969d87e#diff-b5bcf99952b7e15d54b1cb08438fb2337c46db9f1ba8d4bce463ef4a0dfb9168
|
Replaced by #1378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the namespace can be accurately extracted.
Fixes #1374