Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default fabconnect calls to async #836

Merged
merged 2 commits into from
May 27, 2022
Merged

default fabconnect calls to async #836

merged 2 commits into from
May 27, 2022

Conversation

shorsher
Copy link
Member

@shorsher shorsher commented May 27, 2022 •
edited
Loading

The fabconnect default for /transactions is synchronous. The fabric plugin currently expects async responses, so adding the x-firefly-sync header.

@shorsher shorsher marked this pull request as draft May 27, 2022 17:27
@shorsher shorsher marked this pull request as ready for review May 27, 2022 17:40
peterbroadhurst
peterbroadhurst approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

shorsher and others added 2 commits May 27, 2022 16:19
@shorsher
default fabconnect calls to async
56da7dd 
The fabconnect default for /transactions is synchronous. The fabric
plugin currently expects async responses, so adding the `x-firefly-sync`
header.

Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
@nguyer @shorsher
Disable external link checking when building docs, due to unreliable …
a32802c 
…external servers

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022 •
edited
Loading

Codecov Report

Merging #836 (a32802c) into release-1.0 (971ff47) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           release-1.0      #836   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              324       324           
  Lines            20801     20802    +1     
=============================================
+ Hits             20801     20802    +1
Impacted Files Coverage Δ
internal/blockchain/fabric/fabric.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 971ff47...a32802c. Read the comment docs.

@shorsher shorsher merged commit 61f0a47 into hyperledger:release-1.0 May 27, 2022
@shorsher shorsher deleted the fabric-async branch May 27, 2022 20:31
@shorsher shorsher mentioned this pull request May 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbroadhurst peterbroadhurst peterbroadhurst approved these changes

@nguyer nguyer Awaiting requested review from nguyer

@awrichar awrichar Awaiting requested review from awrichar awrichar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shorsher @codecov-commenter @peterbroadhurst @nguyer