-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop orchestrator for ff_system when moving to network V2 #884
Conversation
Codecov Report
@@ Coverage Diff @@
## main #884 +/- ##
==========================================
- Coverage 99.96% 99.96% -0.01%
==========================================
Files 298 298
Lines 19563 19424 -139
==========================================
- Hits 19557 19418 -139
Misses 5 5
Partials 1 1
Continue to review full report at Codecov.
|
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Alright - this is rebased and ready now. |
Part of FIR-12
In a chain with #883In a chain with #890Background: The legacy
ff_system
namespace is created (ie an orchestrator and managers are initialized) whenever the default namespace is a V1 multiparty network. Theff_system
namespace is initialized with an exact duplicate of the default namespace config (same plugins, same contract addresses, etc).With this PR, if the default namespace (and therefore
ff_system
) migrates to V2 rules, theff_system
orchestrator will be stopped and removed, along with all its children.This should allow legacy networks to cleanly migrate to V2 rules and retire
ff_system
. Notable caveat: once the default namespace is on V2, no other V1 namespaces will be supported.