New Release Workflow & Gha refactoring #1749
Conversation
Signed-off-by: Philipp Schlarb <p.schlarb@esatus.com>
Signed-off-by: pSchlarb <87540518+pSchlarb@users.noreply.github.com>
Signed-off-by: pSchlarb <p.schlarb@esatus.com>
Signed-off-by: pSchlarb <p.schlarb@esatus.com>
Signed-off-by: pSchlarb <p.schlarb@esatus.com>
Signed-off-by: pSchlarb <p.schlarb@esatus.com>
|
Can one of the admins verify this patch? |
Release Workflow Diagram Polishing for PR Signed-off-by: Philipp Schlarb <p.schlarb@esatus.com>
There was a problem hiding this comment.
A few small items to address.
The publish-deb and set-version actions should be removed now that they are in the indy-shared-gha repo.
The ubuntu 16.04 build scripts were removed from this PR, should they have also been removed from the indy-plenum PR; hyperledger/indy-plenum#1590
Renaming of build-scripts/ubuntu-2004/build-indy-node.sh to build-scripts/ubuntu-2004/build-indy_node.sh. This is inconsistent with the renaming of the equivalent script in plenum from build-scripts/ubuntu-2004/build-indy-plenum.sh to build-scripts/ubuntu-2004/build-plenum.sh
Also see hyperledger/indy-plenum#1592
.github/workflows/tag.yaml
Outdated
| with: | ||
| python-version: '3.8' | ||
| - name: Install deps for version change | ||
| run: pip install base58 |
There was a problem hiding this comment.
| run: pip install base58 | |
| run: | | |
| sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 9692C00E657DDE61 | |
| sudo add-apt-repository 'deb https://hyperledger.jfrog.io/artifactory/indy focal dev' | |
| sudo apt-get update -y && sudo apt-get install -y \ | |
| rocksdb=5.8.8 \ | |
| libgflags-dev \ | |
| libsnappy-dev \ | |
| zlib1g-dev \ | |
| libbz2-dev \ | |
| liblz4-dev \ | |
| libgflags-dev \ | |
| pip install packaging \ | |
| importlib_metadata==3.10.1 \ | |
| indy-plenum==1.13.0.dev14 \ | |
| pyzmq==22.3.0 |
This ugliness is due to having to install indy-plenum plus it's minimal set of dependencies in order to use the bump_version.sh script.
There was a problem hiding this comment.
I will add it but wouldn't it be wiser to change the bump_version.sh script to only change the __version__.json?
There was a problem hiding this comment.
I can see why it was done the way it is, for consistency in version number handling, but the result here in indy-node is having to load the additional dependencies.
That was intentionally done to match the |
pSchlarb
force-pushed
the
GHARefactoring
branch
2 times, most recently
from
5810660 to
20d709c
Compare
Signed-off-by: Philipp Schlarb <p.schlarb@esatus.com>
- Separate the `apt-get` and `pip` commands in tag workflow. - Fix job reference in release PR workflow. Signed-off-by: Wade Barnes <wade@neoterictech.ca>
- Factor out into a shared action. Signed-off-by: Wade Barnes <wade@neoterictech.ca> `````````````````````````````````````
WadeBarnes
force-pushed
the
GHARefactoring
branch
from
84ae3af to
0b82d76
Compare
Refactoring of GHA Workflows and New Release Workflow.
PR and Push flows now only trigger, when python files have changed.
WIP:
New Release Workflow:
