-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Ubuntu 20.04 #1522
Upgrade Ubuntu 20.04 #1522
Conversation
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
[UP-34]: add LEDGERS_FREEZE and GET_FROZEN_LEDGERS transactions
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
…stNodeDelay Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
@ryMarsh44, @Toktar, @adenishchenko, What is the relationship between this PR and #1509? Can #1509 be closed in favor of this PR? |
@ryMarsh44, @Toktar, @adenishchenko, @udosson, If I understand correctly, based on the Indy Contributors call today, this PR can be taken out of WIP status. Is that correct? |
@WadeBarnes, #1509 can be closed. This PR contains the previous one. |
But all tests pass locally |
@Toktar, @askolesov, This PR contains GHA workflows @udosson developed for the Ubuntu 20.04 upgrade. Does it not? |
@WadeBarnes Yes, it is. But GHAs for Ubuntu20.04 doesn't work partly, and we are working on them in my fork https://github.com/Toktar/indy-plenum/actions/runs/701558875 |
@Toktar, Great!. I'm getting the same results. Since you're already working on it I'll leave it to you. There have been some updates to the workflows that need to be integrated in order to fix some of the issues you are seeing and also integrate the CD portion of the flows that @ianco and @udosson added to the version in the main branch; https://github.com/hyperledger/indy-plenum/blob/master/.github/workflows/build.yaml Namely these changes need to be integrated while the detection of Ubuntu 16.04 vs 20.04 is retained from the version on this branch: |
.github/workflows/build.yaml
Outdated
on: | ||
push: | ||
branches: | ||
- master | ||
- gha-ubuntu-20.04 | ||
pull_request: | ||
branches: | ||
- master | ||
- gha-ubuntu-20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Toktar, also, if you add ubuntu-20.04-upgrade
to the list of branches, the workflows will be triggered when you commit to this PR.
Signed-off-by: Anton Denishchenko <anton.denishchenko@evernym.com>
Signed-off-by: Anton Denishchenko <anton.denishchenko@evernym.com>
Signed-off-by: Anton Denishchenko <anton.denishchenko@evernym.com>
Signed-off-by: anton.denishchenko <anton.denishchenko@dsr-corporation.com>
253d083
to
ef76945
Compare
Testing the latest updates over here; https://github.com/WadeBarnes/indy-plenum/actions/runs/726225931 |
Yeah, it was also running in Anton's repo but failing here for some reason |
@WadeBarnes Yes, I fixed it and tested in my repo https://github.com/adenishchenko/indy-plenum/actions/runs/718983014. All tests pass but in the PR we still have an issue with a secret, I think. |
All tests are passing on Ubuntu 20.04. There is still some work to be done on the GHA workflows, but that can be done on follow-up PRs. I'd like to get this PR merged into the Any objections, @adenishchenko, @Toktar, @askolesov, @udosson? |
No objections, but how are we going to do the first release on Ubuntu 16 if we merge it now? |
This is expected. PRs don't have access to the repository secrets. |
This is going into the |
Right, thanks. Too many branches... |
No description provided.