Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CD release into two parts, added caching, and extended Docker file #1526

Merged
merged 4 commits into from
Mar 19, 2021

Conversation

udosson
Copy link
Contributor

@udosson udosson commented Mar 16, 2021

  • Extended the Dockfile with the CD dependencies. It's not necessary anymore to install dependencies and fpm in build_plenum_release job

  • split the build_plenum_release job into two jobs

  • (1) build plenum release and upload deb file as an artifact

  • (2) build all 3rd party dependencies and cache them. Only trigger a new build if the dependencies change

@udosson udosson requested a review from a team as a code owner March 16, 2021 13:28
@sovbot
Copy link
Contributor

sovbot commented Mar 16, 2021

Can one of the admins verify this patch?

Robin Klemens added 2 commits March 16, 2021 16:02
Signed-off-by: udosson <r.klemens@yahoo.de>
Signed-off-by: udosson <r.klemens@yahoo.de>
@Toktar
Copy link
Contributor

Toktar commented Mar 17, 2021

(ci) test this please

Signed-off-by: udosson <r.klemens@yahoo.de>
…ksdb build

Signed-off-by: udosson <r.klemens@yahoo.de>
@WadeBarnes
Copy link
Member

(ci) test this please

@WadeBarnes
Copy link
Member

After several runs to get past timing related test failures, everything checks out; https://github.com/WadeBarnes/indy-plenum/actions/runs/664540395

Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. All steps are working now. Just waiting on the formality of the required ci pass before merging.

@WadeBarnes WadeBarnes merged commit f812a72 into hyperledger:master Mar 19, 2021
@WadeBarnes WadeBarnes mentioned this pull request Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants