UIImageView extension #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return | ||
| } | ||
|
|
||
| guard let image = UIImage.decode(data) else { |
There was a problem hiding this comment.
I think decompression is on the main thread now 💭
There was a problem hiding this comment.
I checked that, the thing is that the task resolves in a random thread every time, so we are good.
There was a problem hiding this comment.
But it's a main queue 😱
Merged
|
Why that? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess it needs further testing in terms of the flashing of the images that we had, but here are some tests with Bad Internet connection and with WiFi:
The flow was this one:
You create a task, you add it to the dictionary, it exists, so you cancel the task, this task completes and then it gives an error, in the closure, done in the background, it removes the value of the task from the dictionary, for some reason that was causing errors since this task was still going on or something, it seems to work, but I'd like further test.