Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIImageView extension 2 #8

Merged
merged 11 commits into from
Dec 1, 2015
Merged

UIImageView extension 2 #8

merged 11 commits into from
Dec 1, 2015

Conversation

vadymmarkov
Copy link
Contributor

@RamonGilabert @zenangst

  1. This is implemented with not-static fetcher, so we set a fetcher as a property of UIImageView, then cancel the task when needed and set the fetcher to nil.
  2. Thread handling are done in the fetcher also.
  3. Solves the issue with reusable cells.

So now I think we have to compare this one with #7 to understand which one is more safe and clean.

zenangst added a commit that referenced this pull request Dec 1, 2015
@zenangst
Merge pull request #8 from hyperoslo/imporve/uiimageview-extension
bfd6271 
UIImageView extension 2
@zenangst zenangst merged commit bfd6271 into master Dec 1, 2015
@zenangst zenangst deleted the imporve/uiimageview-extension branch December 1, 2015 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vadymmarkov @zenangst