fix: restore service list as flat list #521
Conversation
Codecov Report
@@ Coverage Diff @@
## main #521 +/- ##
==========================================
+ Coverage 85.59% 85.60% +0.01%
==========================================
Files 754 757 +3
Lines 15504 15518 +14
Branches 1839 1839
==========================================
+ Hits 13270 13284 +14
Misses 2203 2203
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
|
||
| .input { | ||
| @include font-title; | ||
| @include body-1-regular($gray-9); |
There was a problem hiding this comment.
this isn't really part of this change, but noticed it in the UX for this page.
This comment has been minimized.
This comment has been minimized.
|
After this change: Endpoint from endpoint list:
Endpoint from service's endpoint list:
Services list:
Endpoints list:
|
| </div> | ||
| ` | ||
| }) | ||
| export class EndpointListComponent {} |
There was a problem hiding this comment.
Have we have started calling apis as endpoints in the code as well? Would that cause confusion with existing components for API like ApiDetailBreadcrumbResolver?
There was a problem hiding this comment.
It's a bit mixed in code. We should get it all consistent, but figured if we're adding new stuff to make it accurate. Another change that should happen is flattening the structure of pages (removing the /apis parent dir)
| export const environment = { | ||
| production: false, | ||
| graphqlUri: 'http://localhost:2020/graphql' | ||
| graphqlUri: 'http://localhost:23431/graphql' |
There was a problem hiding this comment.
I think it should be 2020 only right?
There was a problem hiding this comment.
There was a problem hiding this comment.
yeah my bad. this is the HT graphql port (23431) but usually devs are running against a full cluster which puts everything behind 2020.
Description
Restore flat service list (not the tree variant) in addition to the new flat endpoint list.
Testing
Ran unit tests, verified UI locally
Checklist: