fix: restore service list as flat list #521
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { ChangeDetectionStrategy, Component } from '@angular/core'; | ||
| import { endpointListDashboard } from './endpoint-list.dashboard'; | ||
|
|
||
| @Component({ | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| template: ` | ||
| <div class="vertical-flex-layout"> | ||
| <ht-page-header></ht-page-header> | ||
| <ht-navigable-dashboard navLocation="${endpointListDashboard.location}"></ht-navigable-dashboard> | ||
| </div> | ||
| ` | ||
| }) | ||
| export class EndpointListComponent {} | ||
|
There was a problem hiding this comment. Have we have started calling apis as endpoints in the code as well? Would that cause confusion with existing components for API like There was a problem hiding this comment. It's a bit mixed in code. We should get it all consistent, but figured if we're adding new stuff to make it accurate. Another change that should happen is flattening the structure of pages (removing the |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { NgModule } from '@angular/core'; | ||
| import { PageHeaderModule } from '@hypertrace/components'; | ||
| import { NavigableDashboardModule } from '@hypertrace/distributed-tracing'; | ||
| import { ObservabilityDashboardModule } from '../../../shared/dashboard/observability-dashboard.module'; | ||
| import { EndpointListComponent } from './endpoint-list.component'; | ||
| import { endpointListDashboard } from './endpoint-list.dashboard'; | ||
|
|
||
| @NgModule({ | ||
| imports: [ | ||
| ObservabilityDashboardModule, | ||
| PageHeaderModule, | ||
| NavigableDashboardModule.withDefaultDashboards(endpointListDashboard) | ||
| ], | ||
| declarations: [EndpointListComponent] | ||
| }) | ||
| export class EndpointListModule {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| import { CoreTableCellRendererType, TableSortDirection } from '@hypertrace/components'; | ||
| import { DashboardDefaultConfiguration, TracingTableCellType } from '@hypertrace/distributed-tracing'; | ||
| import { ObservabilityTableCellType } from '../../../shared/components/table/observability-table-cell-type'; | ||
|
|
||
| export const serviceListDashboard: DashboardDefaultConfiguration = { | ||
| location: 'SERVICE_LIST', | ||
| json: { | ||
| type: 'table-widget', | ||
| id: 'service-list.table', | ||
| searchAttribute: 'name', | ||
| columns: [ | ||
| { | ||
| type: 'table-widget-column', | ||
| title: 'Name', | ||
| display: ObservabilityTableCellType.Entity, | ||
| width: '30%', | ||
| value: { | ||
| type: 'entity-specification' | ||
| } | ||
| }, | ||
| { | ||
| type: 'table-widget-column', | ||
| title: 'p99 Latency', | ||
| display: TracingTableCellType.Metric, | ||
| value: { | ||
| type: 'metric-aggregation', | ||
| metric: 'duration', | ||
| aggregation: 'p99' | ||
| }, | ||
| sort: TableSortDirection.Descending | ||
| }, | ||
| { | ||
| type: 'table-widget-column', | ||
| title: 'Avg Latency', | ||
| display: TracingTableCellType.Metric, | ||
| value: { | ||
| type: 'metric-aggregation', | ||
| metric: 'duration', | ||
| aggregation: 'avg' | ||
| } | ||
| }, | ||
| { | ||
| type: 'table-widget-column', | ||
| title: 'Errors/s', | ||
| display: CoreTableCellRendererType.Number, | ||
| value: { | ||
| type: 'metric-aggregation', | ||
| metric: 'errorCount', | ||
| aggregation: 'avgrate_sec' | ||
| } | ||
| }, | ||
| { | ||
| type: 'table-widget-column', | ||
| title: 'Errors', | ||
| display: CoreTableCellRendererType.Number, | ||
| value: { | ||
| type: 'metric-aggregation', | ||
| metric: 'errorCount', | ||
| aggregation: 'sum' | ||
| } | ||
| }, | ||
| { | ||
| type: 'table-widget-column', | ||
| title: 'Calls/s', | ||
| display: CoreTableCellRendererType.Number, | ||
| value: { | ||
| type: 'metric-aggregation', | ||
| metric: 'numCalls', | ||
| aggregation: 'avgrate_sec' | ||
| } | ||
| }, | ||
| { | ||
| type: 'table-widget-column', | ||
| title: 'Calls', | ||
| display: CoreTableCellRendererType.Number, | ||
| value: { | ||
| type: 'metric-aggregation', | ||
| metric: 'numCalls', | ||
| aggregation: 'sum' | ||
| } | ||
| } | ||
| ], | ||
| data: { | ||
| type: 'entity-table-data-source', | ||
| entity: 'SERVICE' | ||
| } | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import { NgModule } from '@angular/core'; | ||
| import { RouterModule } from '@angular/router'; | ||
| import { TraceRoute } from '@hypertrace/common'; | ||
| import { | ||
| ApiDetailBreadcrumbResolver, | ||
| ApiDetailService, | ||
| EndpointListComponent, | ||
| EndpointListModule | ||
| } from '@hypertrace/observability'; | ||
|
|
||
| const ROUTE_CONFIG: TraceRoute[] = [ | ||
| { | ||
| path: '', | ||
| component: EndpointListComponent | ||
| }, | ||
| { | ||
| path: `endpoint/:${ApiDetailService.API_ID_PARAM_NAME}`, | ||
| resolve: { | ||
| breadcrumb: ApiDetailBreadcrumbResolver | ||
| }, | ||
| loadChildren: () => import('../api-detail/api-detail-routing.module').then(module => module.ApiDetailRoutingModule) | ||
| } | ||
| ]; | ||
|
|
||
| @NgModule({ | ||
| imports: [RouterModule.forChild(ROUTE_CONFIG), EndpointListModule] | ||
| }) | ||
| export class EndpointRoutingModule {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't really part of this change, but noticed it in the UX for this page.