Skip to content

Conversation

arjunlalb
Copy link
Contributor

Description

Add Exit calls column to trace views.

Testing

Manual verification done.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@arjunlalb arjunlalb requested a review from a team as a code owner February 26, 2021 08:28
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #643 (6b1fd97) into main (b43ce2e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #643   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files         778      778           
  Lines       16030    16030           
  Branches     2068     2068           
=======================================
  Hits        13662    13662           
  Misses       2333     2333           
  Partials       35       35           
Impacted Files Coverage Δ
...apis/api-detail/traces/api-trace-list.dashboard.ts 100.00% <ø> (ø)
...vice-detail/traces/service-trace-list.dashboard.ts 100.00% <ø> (ø)
...y/src/pages/explorer/explorer-dashboard-builder.ts 88.88% <ø> (ø)
projects/observability/src/public-api.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b43ce2e...6b1fd97. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

kotharironak
kotharironak previously approved these changes Feb 26, 2021
Copy link

@kotharironak kotharironak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Have verified locally by using docker-compose set up by using this and PR - hypertrace/hypertrace-service#74
hypertrace/hypertrace-service#74 (comment)

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld dismissed their stale review February 26, 2021 12:37

Holding for full implementation

@arjunlalb
Copy link
Contributor Author

@aaron-steinfeld Full implementation of this feature has been done.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit 5d93503 into main Mar 4, 2021
@arjunlalb arjunlalb deleted the api-exit-calls branch March 4, 2021 16:07
@github-actions
Copy link

github-actions bot commented Mar 4, 2021

Unit Test Results

    4 files  ±0  242 suites  ±0   14m 38s ⏱️ +41s
869 tests ±0  869 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
873 runs  ±0  873 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5d93503. ± Comparison against base commit b43ce2e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants