Skip to content

feat: add api exit calls column to trace views #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 4, 2021
Merged

feat: add api exit calls column to trace views #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ffa202e
feat: add api exit calls column to trace views
arjunlalb Feb 26, 2021
3aff434
Merge branch 'main' into api-exit-calls
arjunlalb Feb 26, 2021
7fad7ea
fix: disable max line count in file
arjunlalb Feb 26, 2021
2dd1d6f
Merge branch 'api-exit-calls' of github.com:hypertrace/hypertrace-ui …
arjunlalb Feb 26, 2021
5f8abdc
fix: update test
arjunlalb Feb 26, 2021
0dae2e5
fix: export visualization request def
arjunlalb Feb 26, 2021
6b1fd97
Merge branch 'main' into api-exit-calls
arjunlalb Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions projects/observability/src/pages/apis/api-detail/traces/api-trace-list.dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,15 @@ export const apiTraceListDashboard = {
type: 'api-trace-navigation-handler'
}
},
{
type: 'table-widget-column',
title: 'Exit Calls',
filterable: true,
value: {
type: 'attribute-specification',
attribute: 'apiExitCalls'
}
},
{
type: 'table-widget-column',
title: 'Status',
Expand Down
9 changes: 9 additions & 0 deletions projects/observability/src/pages/apis/service-detail/traces/service-trace-list.dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,15 @@ export const serviceTraceListDashboard = {
type: 'api-trace-navigation-handler'
}
},
{
type: 'table-widget-column',
title: 'Exit Calls',
filterable: true,
value: {
type: 'attribute-specification',
attribute: 'apiExitCalls'
}
},
{
type: 'table-widget-column',
title: 'Status',
Expand Down
1 change: 1 addition & 0 deletions projects/observability/src/pages/explorer/explorer-dashboard-builder.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ describe('Explorer dashboard builder', () => {
expect.objectContaining({ title: 'Type' }),
expect.objectContaining({ title: 'Service' }),
expect.objectContaining({ title: 'Endpoint' }),
expect.objectContaining({ title: 'Exit Calls' }),
expect.objectContaining({ title: 'Status' }),
expect.objectContaining({ title: 'Duration' }),
expect.objectContaining({ title: 'Start Time' }),
Expand Down
13 changes: 13 additions & 0 deletions projects/observability/src/pages/explorer/explorer-dashboard-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import { LegendPosition } from '../../shared/components/legend/legend.component'
import { ExplorerVisualizationCartesianDataSourceModel } from '../../shared/dashboard/data/graphql/explorer-visualization/explorer-visualization-cartesian-data-source.model';
import { ObservabilityTraceType } from '../../shared/graphql/model/schema/observability-traces';

// tslint:disable: max-file-line-count
export class ExplorerDashboardBuilder {
private readonly requestSubject: Subject<ExploreVisualizationRequest> = new ReplaySubject(1);

Expand Down Expand Up @@ -201,6 +202,18 @@ export class ExplorerDashboardBuilder {
type: 'api-trace-navigation-handler'
}
},
{
type: 'table-widget-column',
title: 'Exit Calls',
filterable: true,
value: {
type: 'attribute-specification',
attribute: 'apiExitCalls'
},
'click-handler': {
type: 'api-trace-navigation-handler'
}
},
{
type: 'table-widget-column',
title: 'Status',
Expand Down
3 changes: 2 additions & 1 deletion projects/observability/src/public-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ export * from './shared/components/explore-query-editor/explore-query-editor.com
export * from './shared/components/explore-query-editor/explore-query-editor.module';
export {
ExploreSeries,
ExploreRequestState
ExploreRequestState,
ExploreVisualizationRequest
} from './shared/components/explore-query-editor/explore-visualization-builder';
export * from './shared/dashboard/data/graphql/explore/explore-cartesian-data-source.model';

Expand Down