refactor: fixing table css so that it can work inside flex container #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandtiwary
commented
Mar 9, 2021
| styleUrls: ['./table.component.scss'], | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| template: ` | ||
| <div class="table"> |
There was a problem hiding this comment.
same class was assigned to cdk-table too.
Codecov Report
@@ Coverage Diff @@
## main #668 +/- ##
=======================================
Coverage 85.23% 85.23%
=======================================
Files 779 779
Lines 16042 16042
Branches 2068 2068
=======================================
Hits 13674 13674
Misses 2333 2333
Partials 35 35
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
jake-bassett
approved these changes
Mar 9, 2021
aaron-steinfeld
approved these changes
Mar 9, 2021
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
refactor: fixing table css so that it can work inside flex container
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.