Skip to content

refactor: fixing table css so that it can work inside flex container #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2021
Merged

refactor: fixing table css so that it can work inside flex container #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05e96b4
refactor: fixing table css so that it can work inside flex container
anandtiwary Mar 9, 2021
fb4babb
Merge branch 'main' into table-flex-container
anandtiwary Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions projects/components/src/table/table.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
@import 'mixins';
@import 'layout';

.table {
.table-container {
position: relative;
display: flex;
flex-direction: column;
flex: 1 1;
height: 100%;
width: 100%;
}

.table {
display: flex;
flex-direction: column;
flex: 1 1 0;
height: 100%;
width: 100%;
overflow: auto;
Expand Down Expand Up @@ -116,6 +123,7 @@
.pagination-controls {
position: fixed;
width: 100%;
height: #{$paginator-height};
bottom: 0;
background: white;
}
2 changes: 1 addition & 1 deletion projects/components/src/table/table.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ import { TableColumnConfigExtended, TableService } from './table.service';
styleUrls: ['./table.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<div class="table">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same class was assigned to cdk-table too.

<div class="table-container">
<cdk-table
*ngIf="this.dataSource"
[multiTemplateDataRows]="this.isDetailType()"
Expand Down