Skip to content

Conversation

arjunlalb
Copy link
Contributor

Description

Multi select options should overflow.

Testing

Manually verified.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@arjunlalb arjunlalb requested a review from a team as a code owner March 18, 2021 13:26
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #702 (0e7dfa9) into main (db67f98) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #702   +/-   ##
=======================================
  Coverage   85.16%   85.16%           
=======================================
  Files         782      782           
  Lines       16042    16042           
  Branches     2048     2048           
=======================================
  Hits        13662    13662           
  Misses       2347     2347           
  Partials       33       33           
Impacted Files Coverage Δ
...ponents/src/multi-select/multi-select.component.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db67f98...0e7dfa9. Read the comment docs.

@github-actions

This comment has been minimized.

@arjunlalb arjunlalb merged commit 3b2a8cd into main Mar 18, 2021
@arjunlalb arjunlalb deleted the multi-select-options-overflow branch March 18, 2021 14:18
@github-actions
Copy link

Unit Test Results

    4 files  ±0  244 suites  ±0   14m 59s ⏱️ +38s
877 tests ±0  877 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
881 runs  ±0  881 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3b2a8cd. ± Comparison against base commit db67f98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants