Skip to content

fix: allow multi select options to overflow #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2021
Merged

fix: allow multi select options to overflow #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions projects/components/src/multi-select/multi-select.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,17 @@
@include dropdown(6px);
min-width: 120px;
display: flex;
height: 100%;
flex-direction: column;

.divider {
padding: 0px 16px 4px 16px;
}

.multi-select-options {
overflow: auto;
}

.multi-select-option {
display: flex;
height: 34px;
Expand Down
30 changes: 16 additions & 14 deletions projects/components/src/multi-select/multi-select.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,20 +88,22 @@ import { MultiSelectJustify } from './multi-select-justify';
</ng-container>
</ng-container>

<div
*ngFor="let item of this.filteredOptions$ | async"
(click)="this.onSelectionChange(item)"
class="multi-select-option"
>
<input class="checkbox" type="checkbox" [checked]="this.isSelectedItem(item)" />
<ht-icon
class="icon"
*ngIf="item.icon"
[icon]="item.icon"
size="${IconSize.ExtraSmall}"
[color]="item.iconColor"
></ht-icon>
<span class="label">{{ item.label }}</span>
<div class="multi-select-options">
<div
*ngFor="let item of this.filteredOptions$ | async"
(click)="this.onSelectionChange(item)"
class="multi-select-option"
>
<input class="checkbox" type="checkbox" [checked]="this.isSelectedItem(item)" />
<ht-icon
class="icon"
*ngIf="item.icon"
[icon]="item.icon"
size="${IconSize.ExtraSmall}"
[color]="item.iconColor"
></ht-icon>
<span class="label">{{ item.label }}</span>
</div>
</div>
</div>
</ht-popover-content>
Expand Down