Skip to content

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Apr 16, 2021

Description

Turn on paginator when total items are greater than the smallest item in the page size drop-down menu.

Testing

Visual testing

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #777 (f4eb75b) into main (ede25fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #777   +/-   ##
=======================================
  Coverage   85.40%   85.40%           
=======================================
  Files         791      791           
  Lines       16155    16155           
  Branches     2060     2060           
=======================================
  Hits        13797    13797           
  Misses       2327     2327           
  Partials       31       31           
Impacted Files Coverage Δ
...ts/components/src/paginator/paginator.component.ts 95.08% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede25fc...f4eb75b. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu marked this pull request as ready for review April 16, 2021 19:08
@palbizu palbizu requested a review from a team as a code owner April 16, 2021 19:08
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu requested a review from aaron-steinfeld April 16, 2021 20:04
@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 1386e83 into main Apr 16, 2021
@palbizu palbizu deleted the TurnOnPagination branch April 16, 2021 20:12
@github-actions
Copy link

Unit Test Results

    4 files  ±0  249 suites  ±0   14m 37s ⏱️ -38s
892 tests +1  892 ✔️ +1  0 💤 ±0  0 ❌ ±0 
898 runs  +1  898 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 1386e83. ± Comparison against base commit ede25fc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants