Skip to content

feat: turn on paginator when total Items are larger than page size #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 16, 2021
Merged

feat: turn on paginator when total Items are larger than page size #777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7e4ab17
feat: turn on paginator when totalItems is larger than page size
Apr 16, 2021
c6dd9c7
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into TurnO…
Apr 16, 2021
77bd6b5
fix: solving nit
Apr 16, 2021
79069d5
fix: adding UT
Apr 16, 2021
8627109
fix: changing label
Apr 16, 2021
fa88ee3
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into TurnO…
Apr 16, 2021
8eddf99
fix: fixing ut
Apr 16, 2021
011cd58
fix: rollback pageSizeOptions default value
Apr 16, 2021
f4eb75b
fix: label fixed
Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions projects/components/src/paginator/paginator.component.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,15 @@ describe('Paginator component', () => {
expect(spectator.query(LabelComponent)?.label).toEqual('1-50 of 50');
expect(spectator.component.hasNextPage()).toBe(false);
});

test('should hide the paginator when totalItems is less than the pageSizeOptions options', () => {
const spectator = createHost(`<ht-paginator [totalItems]="totalItems"></ht-paginator>`, {
hostProps: {
totalItems: 20
}
});

const paginator = spectator.query('.paginator')!;
expect(paginator).toBeNull();
});
});
2 changes: 1 addition & 1 deletion projects/components/src/paginator/paginator.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { PaginationProvider } from './paginator-api';
styleUrls: ['./paginator.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
template: `
<div class="paginator" *ngIf="this.totalItems">
<div class="paginator" *ngIf="this.totalItems && this.totalItems > this.pageSizeOptions[0]">
<ht-label
class="label"
label="{{ this.firstItemNumberForPage() }}-{{ this.lastItemNumberForPage() }} of {{ this.totalItems }}"
Expand Down