Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW-52171 Implement phone input type #11

Merged
merged 6 commits into from
May 8, 2019

Conversation

ymoskovko-epam
Copy link

No description provided.

@ymoskovko-epam ymoskovko-epam changed the base branch from master to development May 7, 2019 19:59
Copy link

@gmeyer-hw gmeyer-hw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!!!, I added a few comments

toolBar.isTranslucent = true
toolBar.tintColor = Theme.themeColor
toolBar.sizeToFit()
extension UIToolbar {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsaini-hw Do we really need to extend all the toolbars across the app instead of customization for our particular needs?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleksii-lubianyi-epam We are not extending any existing method but giving an opportunity to extend all the toolbars if required using this method

…t-type2

* development:
  feature/HW-52309-Use-country-from-user-accountt (#4)
@ekan-hw ekan-hw merged commit fe25eb3 into development May 8, 2019
ymoskovko-epam added a commit that referenced this pull request May 9, 2019
Implement phone input type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants