-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HW-52171 Implement phone input type #11
Merged
ekan-hw
merged 6 commits into
development
from
feature/HW-52171-implement-phone-input-type2
May 8, 2019
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7b4f607
implemented Phone and Date widgets
ymoskovko-epam 2b48f04
implemented common logic in ToolbarPicker
ymoskovko-epam 2cdc98d
Merge remote-tracking branch 'refs/remotes/origin/development'
jsaini-hw feb6ec8
Updated logic to create extension of UIToolBar()
jsaini-hw ba7b0f8
fixed PR's comments
ymoskovko-epam 6374658
Merge branch 'development' into feature/HW-52171-implement-phone-inpu…
ymoskovko-epam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| // | ||
| // Copyright 2018 - Present Hyperwallet | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy of this software | ||
| // and associated documentation files (the "Software"), to deal in the Software without restriction, | ||
| // including without limitation the rights to use, copy, modify, merge, publish, distribute, | ||
| // sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in all copies or | ||
| // substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING | ||
| // BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND | ||
| // NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
| // DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
|
||
| import HyperwalletSDK | ||
|
|
||
| /// Represents the date input widget. | ||
| final class DateWidget: TextWidget { | ||
| var toolbar = UIToolbar() | ||
| private var datePicker: UIDatePicker! | ||
|
|
||
| private static var dateFormatter: DateFormatter = { | ||
| let formatter = DateFormatter() | ||
| formatter.dateFormat = "date_format".localized() | ||
| return formatter | ||
| }() | ||
|
|
||
| override func setupLayout(field: HyperwalletField) { | ||
| super.setupLayout(field: field) | ||
| setupDatePicker() | ||
| toolbar.setupToolBar(target: self, action: #selector(self.doneButtonTapped)) | ||
| setupTextField() | ||
| } | ||
|
|
||
| private func setupDatePicker() { | ||
| datePicker = UIDatePicker(frame: .zero) | ||
| datePicker.datePickerMode = .date | ||
| datePicker.accessibilityIdentifier = "DateWidgetPickerAccessibilityIdentifier" | ||
| } | ||
|
|
||
| private func setupTextField() { | ||
| textField.inputView = datePicker | ||
| textField.inputAccessoryView = toolbar | ||
| textField.delegate = self | ||
| } | ||
|
|
||
| @objc | ||
| private func updateTextField() { | ||
| textField.text = DateWidget.dateFormatter.string(from: datePicker.date) | ||
| } | ||
|
|
||
| @objc | ||
| private func doneButtonTapped() { | ||
| updateTextField() | ||
| textField.resignFirstResponder() | ||
| } | ||
|
|
||
| override func textFieldDidBeginEditing(_ textField: UITextField) { | ||
| super.textFieldDidBeginEditing(textField) | ||
| if let dateFromText = DateWidget.dateFormatter.date(from: value()) { | ||
| datePicker.date = dateFromText | ||
| } else { | ||
| datePicker.date = Date() | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsaini-hw Do we really need to extend all the toolbars across the app instead of customization for our particular needs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oleksii-lubianyi-epam We are not extending any existing method but giving an opportunity to extend all the toolbars if required using this method