Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Detail Wrapping #310

Merged
merged 10 commits into from
Apr 9, 2021
Merged

Transaction Detail Wrapping #310

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b3d3df1
Currency formatting issue fixed and Add Transfer Icon Fix(Ticket 331 …
aparthibanpaypal Mar 25, 2021
edb6d3f
Copy Transaction Details (#304)
aparthibanpaypal Mar 26, 2021
a290709
Merge branch 'development' into feature/S206
malaw-hw Mar 31, 2021
60023c8
Merge branch 'master' into feature/S206
malaw-hw Mar 31, 2021
c458837
Merge remote-tracking branch 'origin/development' into feature/S206
aparthibanpaypal Mar 31, 2021
fa648cc
Merge remote-tracking branch 'origin/development' into feature/S206
aparthibanpaypal Apr 1, 2021
1e98865
Merge remote-tracking branch 'origin/development' into feature/DTSERW…
aparthibanpaypal Apr 7, 2021
d997f47
Transaction wrapping updated.
aparthibanpaypal Apr 7, 2021
6dc1ed5
Merge remote-tracking branch 'origin/development' into feature/DTSERW…
aparthibanpaypal Apr 8, 2021
0e5ee66
Reload Issue for Wrapping
aparthibanpaypal Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Receipt/Sources/ListReceiptController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ final class ListReceiptController: UITableViewController {
listReceiptCell.createdOnLabel.isUserInteractionEnabled = false
listReceiptCell.currencyLabel.isUserInteractionEnabled = false
listReceiptCell.accessoryType = .disclosureIndicator
listReceiptCell.layoutIfNeeded()
}
return cell
}
Expand All @@ -100,7 +101,7 @@ final class ListReceiptController: UITableViewController {
}

override public func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
return Theme.Cell.height
return UITableView.automaticDimension
}

/// Returns title for header
Expand Down
3 changes: 2 additions & 1 deletion Receipt/Sources/ReceiptDetailController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ final class ReceiptDetailController: UITableViewController {
if let tableViewCell = cell as? ReceiptTransactionCell,
let transactionSection = section as? ReceiptDetailSectionTransactionData {
tableViewCell.configure(transactionSection.receipt)
tableViewCell.layoutIfNeeded()
}

case .details:
Expand Down Expand Up @@ -125,6 +126,6 @@ extension ReceiptDetailController {
}

override public func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
return indexPath.section == 0 ? Theme.Cell.height : Theme.Cell.smallHeight
return indexPath.section == 0 ? UITableView.automaticDimension : Theme.Cell.smallHeight
}
}
4 changes: 3 additions & 1 deletion Receipt/Sources/ReceiptTransactionCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ final class ReceiptTransactionCell: UITableViewCell {
lazy var receiptTypeLabel: UILabel = {
let label = UILabel(frame: .zero)
label.accessibilityIdentifier = "receiptTransactionTypeLabel"
label.lineBreakMode = .byWordWrapping
label.numberOfLines = 0
label.allowTextSelection()
return label
}()
Expand Down Expand Up @@ -105,7 +107,7 @@ final class ReceiptTransactionCell: UITableViewCell {
stackView.axis = .horizontal
stackView.alignment = .center
stackView.distribution = .fill
stackView.spacing = 8
stackView.spacing = 2

stackView.addArrangedSubview(leftLabel)
stackView.addArrangedSubview(rightLabel)
Expand Down