Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Detail Wrapping #310

Merged

Conversation

aparthibanpaypal
Copy link
Contributor

PR for review and testing

aparthibanpaypal and others added 8 commits March 25, 2021 13:03
…and 507) (#303)

* Currency formatting issue fixed.

* Add transfer method icon updated.

* testAddTransferMethod_createBankAccountInvalidRouting skipped for travis

* Changes for travis

* Review comments updated
* Adding UILabel Extension

* Updating receipts cells

* Text selection background color updated.

* Selection color updated.

* Disable override issue.

* Disabled text selection in Receipts List

* Fixed failing existing test cases.

* Added UI Test for text selection.

* Fixed testReceiptDetail_verifyTextSelection

* Created textSelectionColor in Theme for Label

* Updated readme file with textSelectionColor property.
@SaiNarendran SaiNarendran added the Ready To Test This PR is ready to test label Apr 7, 2021
shanavas123
shanavas123 previously approved these changes Apr 8, 2021
Copy link

@SaiNarendran SaiNarendran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refresh issue & content missing issue in Spanish to be fixed if time permits.

@SaiNarendran SaiNarendran self-requested a review April 9, 2021 10:46
@SaiNarendran SaiNarendran added Ready To Merge This PR has been tested and is ready to merge and removed Ready To Test This PR is ready to test labels Apr 9, 2021
@jsaini-hw jsaini-hw merged commit e33f730 into development Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge This PR has been tested and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants