Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic: overhaul the inter-frame communication system #3533

Closed
10 of 13 tasks
esanzgar opened this issue Jun 21, 2021 · 0 comments · Fixed by #3903
Closed
10 of 13 tasks

Epic: overhaul the inter-frame communication system #3533

esanzgar opened this issue Jun 21, 2021 · 0 comments · Fixed by #3903

Comments

@esanzgar
Copy link
Contributor

esanzgar commented Jun 21, 2021 •
edited
Loading

After a full examination of the inter-frame communication system, we proposed a plan with different options #3403. We decided to go ahead and evaluate the option of using MessageChannel API.

These are the steps I envision next:

Other steps we could take in the future could be:

  • cleanup, consolidation or removal of AnnotationSync, or Bridge.
  • use JSON-RPC for all the postMessage communication.
  • replace current lms <-> sidebar communication.
This was referenced Jun 21, 2021
Closed
Closed
@esanzgar esanzgar mentioned this issue Jun 29, 2021
Closed
@robertknight robertknight mentioned this issue Jul 21, 2021
Merged
2 tasks
This was referenced Jul 29, 2021
Closed
Closed
@esanzgar esanzgar mentioned this issue Jul 30, 2021
Closed
esanzgar added a commit that referenced this issue Sep 6, 2021
@esanzgar
Add cross-origin annotatable iframe dev server scenario
533b0e4 
The current inter-frame communication doesn't work if an annotatable
(guest) iframe is from a different origin than the host frame (see
#3611 (comment)). This
will be fixed in a more comprehensive overhaul of the inter-face
communication (see #3533).

Meanwhile, I add a scenario into the local dev server where the
annotatable iframe is from a different origin than the host frame. For
this, I needed to spawn an additional dev server at port 3002):

```
[11:32:50] Dev web server started at http://localhost:3000/
[11:32:50] Dev web server started at http://localhost:3002/
```

Close #3629
@esanzgar esanzgar mentioned this issue Sep 6, 2021
Merged
esanzgar added a commit that referenced this issue Sep 7, 2021
@esanzgar
Add cross-origin annotatable iframe dev server scenario
939ade8 
The current inter-frame communication doesn't work if an annotatable
(guest) iframe is from a different origin than the host frame (see
#3611 (comment)). This
will be fixed in a more comprehensive overhaul of the inter-face
communication (see #3533).

Meanwhile, I add a scenario into the local dev server where the
annotatable iframe is from an origin different than the host frame. For
this, I needed to spawn an additional dev server at port 3002):

```
[11:32:50] Dev web server started at http://localhost:3000/
[11:32:50] Dev web server started at http://localhost:3002/
```

Close #3629
esanzgar added a commit that referenced this issue Sep 7, 2021
@esanzgar
Add cross-origin annotatable iframe dev server scenario
6b2f892 
The current inter-frame communication doesn't work if an annotatable
(guest) iframe is from a different origin than the host frame (see
#3611 (comment)). This
will be fixed in a more comprehensive overhaul of the inter-face
communication (see #3533).

Meanwhile, I add a scenario into the local dev server where the
annotatable iframe is from an origin different than the host frame. For
this, I needed to spawn an additional dev server at port 3002):

```
[11:32:50] Dev web server started at http://localhost:3000/
[11:32:50] Dev web server started at http://localhost:3002/
```

Close #3629
esanzgar added a commit that referenced this issue Sep 8, 2021
@esanzgar
Add cross-origin annotatable iframe dev server scenario
3ff2f1b 
The current inter-frame communication doesn't work if an annotatable
(guest) iframe is from a different origin than the host frame (see
#3611 (comment)). This
will be fixed in a more comprehensive overhaul of the inter-face
communication (see #3533).

Meanwhile, I add a scenario into the local dev server where the
annotatable iframe is from an origin different than the host frame. For
this, I needed to spawn an additional dev server at port 3002):

```
[11:32:50] Dev web server started at http://localhost:3000/
[11:32:50] Dev web server started at http://localhost:3002/
```

Close #3629
esanzgar added a commit that referenced this issue Oct 29, 2021
@esanzgar
Implement PortProvider and PortFinder
cc5b302 
The combination of these two classes enable the discovery and
establishment of `MessageChannel` communication between pairs of frames.

It works with cross-origin frames.

It is the last step of this epic: #3533

Closes: #3695
@esanzgar esanzgar mentioned this issue Oct 29, 2021
Merged
esanzgar added a commit that referenced this issue Nov 2, 2021
@esanzgar
Implement PortProvider and PortFinder
0fe7845 
The combination of these two classes enable the discovery and
establishment of `MessageChannel` communication between pairs of frames.

It works with cross-origin frames.

It is the last step of this epic: #3533

Closes: #3695
esanzgar added a commit that referenced this issue Nov 8, 2021
@esanzgar
Implement PortProvider and PortFinder
d6bb994 
The combination of these two classes enable the discovery and
establishment of `MessageChannel` communication between pairs of frames.

It works with cross-origin frames.

It is the last step of this epic: #3533

Closes: #3695
esanzgar added a commit that referenced this issue Nov 9, 2021
@esanzgar
Implement PortProvider and PortFinder
4622604 
The combination of these two classes enable the discovery and
establishment of `MessageChannel` communication between pairs of frames.

It works with cross-origin frames.

It is the last step of this epic: #3533

Closes: #3695
esanzgar added a commit that referenced this issue Nov 11, 2021
@esanzgar
Implement PortProvider and PortFinder
cdf339d 
The combination of these two classes enable the discovery and
establishment of `MessageChannel` communication between pairs of frames.

It works with cross-origin frames.

It is the last step of this epic: #3533

Closes: #3695
esanzgar added a commit that referenced this issue Nov 15, 2021
@esanzgar
Implement PortProvider and PortFinder
9d11dc8 
The combination of these two classes enable the discovery and
establishment of `MessageChannel` communication between pairs of frames.

It works with cross-origin frames.

It is the last step of this epic: #3533

Closes: #3695
@esanzgar esanzgar mentioned this issue Nov 17, 2021
Merged
@esanzgar esanzgar mentioned this issue Nov 23, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adoption of PortProvider and PortFinder hypothesis/client
1 participant
@esanzgar