New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup tasks after the new inter-frame communication adoption #3957

Closed

3 tasks done

esanzgar opened this issue Nov 23, 2021 · 0 comments

Closed

3 tasks done

Cleanup tasks after the new inter-frame communication adoption #3957

esanzgar opened this issue Nov 23, 2021 · 0 comments

Assignees

Contributor

esanzgar commented Nov 23, 2021 •

edited

Loading

After #3533, there are few reminder cleanup task to fully wrap this chapter:

add integration test Add integration test to check inter-frame communication #4090
fix reportLaunchError according to Adoption of PortProvider and PortFinder #3903 (comment)
create _setupSidebarEvents based on this comment https://github.com/hypothesis/client/pull/3903/files#r751261292 (UI inconsistency in Group menu sub-items #4179)
~~implement a fix for destroy called while discover is running Simplify nomenclature #3929 (comment)~~

The text was updated successfully, but these errors were encountered:

esanzgar self-assigned this

esanzgar closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment