Update to latest prettier-plugin-sort-imports and removed dummy package #5279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what's going on with formatting. This happened to me at first, but then downgraded and upgraded again and that seemed to solve the issue, so I pushed the branch. (edit: We run Here it seems to be even worse, as it's marking a bunch of files as incorrectly formatted. |
|
Issue reported trivago/prettier-plugin-sort-imports#211. Putting this back to draft for now. |
acelaya
force-pushed
the
remove-dummy-module
branch
from
32d1a24 to
f4688a8
Compare
Codecov Report
@@ Coverage Diff @@
## main #5279 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 235 235
Lines 9342 9342
Branches 2239 2239
=======================================
Hits 9266 9266
Misses 76 76 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
robertknight
approved these changes
Feb 24, 2023
This was referenced Feb 24, 2023
Add prettier plugin to sort imports in a consistent and automated way
hypothesis/frontend-shared#877
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 4.1 of
@trivago/prettier-plugin-sort-importsfixes a peer dependency which was not properly marked as optional, so we no longer need the dummy local package replacing it.