Add prettier plugin to sort imports in a consistent way #5109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
approved these changes
Feb 27, 2023
lms/static/scripts/bootstrap.js
Outdated
| @@ -1,17 +1,17 @@ | |||
| // Register the same set of icons that is available in the app. | |||
There was a problem hiding this comment.
This comment belongs with the registerIcons call below.
.prettierrc
Outdated
| "importOrder": [ | ||
| "^[./]" | ||
| ], | ||
| "importOrderSeparation": true | ||
| } |
There was a problem hiding this comment.
In the client we have this configuration in package.json. We might want to do the same here to cut down on the proliferation of config files. In general we can do the same for other tools where a) the tool supports reading config from package.json and b) the config is small and obvious, so doesn't need comments.
There was a problem hiding this comment.
In frontend-shared it is also part of package.json. I have moved it there here as well.
acelaya
force-pushed
the
sort-imports
branch
from
81f7777 to
b666ddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
@trivago/prettier-plugin-sort-importsto the project, so that we can ensure a consistent and automated imports sorting on front-end components viaprettier.This was already introduced in client. See hypothesis/client#5237 and hypothesis/client#5279