Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tab not to use ButtonBase #1072

Closed
lyzadanger opened this issue Jun 1, 2023 · 0 comments · Fixed by #1092
Closed

Update Tab not to use ButtonBase #1072

lyzadanger opened this issue Jun 1, 2023 · 0 comments · Fixed by #1092
Labels
component concerning a UI component that is part of the package API

Comments

@lyzadanger
Copy link
Contributor

Like it says...use styling API on Button instead.
@lyzadanger lyzadanger added component concerning a UI component that is part of the package API code health labels Jun 1, 2023
@lyzadanger lyzadanger mentioned this issue Jun 1, 2023
Open
lyzadanger added a commit that referenced this issue Jun 9, 2023
@lyzadanger
Update Tab to use Button instead of ButtonBase
b0a1bc4 
Fixes #1072
@lyzadanger lyzadanger mentioned this issue Jun 9, 2023
Merged
lyzadanger added a commit that referenced this issue Jun 9, 2023
@lyzadanger
Update Tab to use Button instead of ButtonBase
f528cff 
Fixes #1072
lyzadanger added a commit that referenced this issue Jun 12, 2023
@lyzadanger
Update Tab to use Button instead of ButtonBase
2f35ddc 
Fixes #1072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component concerning a UI component that is part of the package API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Tab and TabList: documentation, don't use ButtonBase hypothesis/frontend-shared
1 participant
@lyzadanger