Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tab and TabList: documentation, don't use ButtonBase #1092

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

lyzadanger
Copy link
Contributor

This PR updates Tab to use Button instead of ButtonBase and updates the pattern-library documentation for Tab and TabList.

Part of #1030
Fixes #1072

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #1092 (6f66803) into main (19ddafc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1092   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           54        54           
  Lines          750       750           
  Branches       276       276           
=========================================
  Hits           750       750           
Impacted Files Coverage Δ
src/components/navigation/Tab.tsx 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lyzadanger lyzadanger merged commit 10f7104 into main Jun 12, 2023
@lyzadanger lyzadanger deleted the update-tabs branch June 12, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Tab not to use ButtonBase
2 participants