Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce specificity of table pattern styling #180

Closed
lyzadanger opened this issue Sep 2, 2021 · 0 comments · Fixed by #193
Closed

Reduce specificity of table pattern styling #180

lyzadanger opened this issue Sep 2, 2021 · 0 comments · Fixed by #193
Labels
design pattern concerning an applied visual design pattern

Comments

@lyzadanger
Copy link
Contributor

Some of the generated selectors in the table pattern mixin violate our implicit specificity contract (i.e. resulting specificity is too high and makes override within apps using it challenging). Need to have a proverbial think about this. There is a generated rule .class-with-table-mixin thead th that is without doubt too specific, but need to have a look at the single-nested element rules as well.
@lyzadanger lyzadanger added the pattern library concerning the build, structure, styling or components for the pattern library label Sep 2, 2021
@lyzadanger lyzadanger added design pattern concerning an applied visual design pattern and removed pattern library concerning the build, structure, styling or components for the pattern library labels Sep 10, 2021
lyzadanger added a commit that referenced this issue Sep 14, 2021
@lyzadanger
Adjust table-styling specificity and organization
bba12b3 
Make sure we're meeting our general specificity contract for styles that
should be override-able by applications. A style that applies to table
headers was nested too deep, making its resulting rule too high in
specificity, and making it thus hard to override in other applications.

Do a bit of rearranging and leveling out of other rules.

Fixes #180
@lyzadanger lyzadanger mentioned this issue Sep 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design pattern concerning an applied visual design pattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add emptyItemsMessage, reduce CSS specificity for Table (table pattern) hypothesis/frontend-shared
1 participant
@lyzadanger