Add emptyItemsMessage, reduce CSS specificity for Table (table pattern)
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we're meeting our general specificity contract for styles that should be override-able by applications. A style that applies to table headers was nested too deep, making its resulting rule too high in specificity, and making it thus hard to override in other applications. Do a bit of rearranging and leveling out of other rules. Fixes #180
Allow the ability to render a message if `items` is empty (and the `Table` is not in a loading state). This obviates the need for parent components to wrangle the message quite as much and simplifies and standardizes styling/position of the message. Fixes #191
lyzadanger
force-pushed
the
table-updates
branch
from
9bb75f7 to
a50b437
Compare
Codecov Report
@@ Coverage Diff @@
## main #193 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 225 227 +2
Branches 76 78 +2
=========================================
+ Hits 225 227 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two updates to the
Tablecomponent and its underlyingtabledesign pattern:tablepattern to meet our general specificity guidelines and to make sure these styles are override-able in applications. Fixes Reduce specificity of table pattern styling #180emptyItemsMessageto theTablecomponent. This arose out of the struggle to render such a message in the LMSFileListand having a heck of a time of it. Woulda been far easier if theTablecould handle appropriately rendering and positioning the message. Fixes Add support for a "no items message" to Table #191These changes will allow several small, helpful updates in the LMS application.