Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a custom title for close button to be provided to Dialogs #1460

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Feb 12, 2024

This will help address an issue found during the last accessibility review:

When buttons perform common actions such as closing a dialog, specificity of the label can be helpful for additional context.

Recommendation for close label:
Instead of “close”, consider using the label “close URL dialog”.

This PR introduces a new closeTitle prop in dialogs, which will propagate as the title prop for nested close buttons.

Currently, these are always rendered as "Close", which is not specific enough.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff02e25) 100.00% compared to head (9f1519b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1460   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           60        60           
  Lines          936       936           
  Branches       353       353           
=========================================
  Hits           936       936           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya requested a review from robertknight February 12, 2024 16:36
@acelaya acelaya merged commit 4f906ba into main Feb 13, 2024
3 checks passed
@acelaya acelaya deleted the close-button-title branch February 13, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants