Add more specific titles to content picker dialog close buttons #6044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
force-pushed
the
close-button-specificity
branch
from
f5e68b3 to
f07d4ef
Compare
acelaya
force-pushed
the
close-button-specificity
branch
from
f07d4ef to
b40e81b
Compare
robertknight
approved these changes
Feb 15, 2024
acelaya
force-pushed
the
close-button-specificity
branch
from
b40e81b to
f1675b8
Compare
acelaya
force-pushed
the
close-button-specificity
branch
from
f1675b8 to
f9b047a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on hypothesis/frontend-shared#1460
All content picker close buttons used to have a generic "Close" title. This PR makes it more specific so that it's clear to non-sighted users what is going to be closed, when using a screen reader.