Do not call onConfirmRow when Enter is pressed in DataTable row children #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
commented
Jun 4, 2024
| wrapper.find('tbody tr a').first().simulate('keydown', { key: 'Enter' }); | ||
|
|
||
| assert.notCalled(onConfirmRow); | ||
| }); |
There was a problem hiding this comment.
This test fails without the changes introduced in DataTable, while the test above keeps passing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1574 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 62 62
Lines 1041 1041
Branches 397 397
=========================================
Hits 1041 1041 ☔ View full report in Codecov by Sentry. |
robertknight
reviewed
Jun 4, 2024
robertknight
approved these changes
Jun 4, 2024
acelaya
force-pushed
the
fix-data-table-enter-handler
branch
from
4d9d82b to
6b4785e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where elements that can be interacted with Enter key would stop the event propagation when rendered inside a
DataTablerow, viarenderItem.